Skip to content

fix(package): fixes #208 by compiling without Ivy - #209

Open
bhuber2010 wants to merge 1 commit into
fulls1z3:masterfrom
bhuber2010:master
Open

fix(package): fixes #208 by compiling without Ivy#209
bhuber2010 wants to merge 1 commit into
fulls1z3:masterfrom
bhuber2010:master

Conversation

@bhuber2010

@bhuber2010 bhuber2010 commented Jul 9, 2020 •
edited
Loading

Copy link
Copy Markdown

** PR Type
What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

** What is the current behavior?
Library can not be used in pre-Ivy projects

Issue Number: #208

** What is the new behavior?
Library works in pre-Ivy projects

** Does this PR introduce a breaking change?

[ ] Yes
[x] No

** Other information
It's currently not recommended to build libraries with Ivy due to potentially losing support for ViewEngine compiled Angular projects.

@bhuber2010
bhuber2010 requested a review from fulls1z3 as a code owner July 9, 2020 19:08
@ghost

ghost commented Jul 9, 2020

Copy link
Copy Markdown

Warnings are found on analyzing the commit fee1501.

2 warnings:

We recommend to address them as possible, for example, update outdated dependencies, fix the tool's configuration, configure sider.yml, turn off unused tools, and so on.

If you are struggling with these errors or warnings, feel free to ask us via chat. 💬

@codecov

codecov Bot commented Jul 9, 2020 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.75%. Comparing base (6329569) to head (fee1501).

Additional details and impacted files 
@@           Coverage Diff           @@
##           master     #209   +/-   ##
=======================================
  Coverage   98.75%   98.75%           
=======================================
  Files           7        7           
  Lines         161      161           
  Branches       47       47           
=======================================
  Hits          159      159           
  Misses          2        2

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@fulls1z3

fulls1z3 commented Jul 8, 2021

Copy link
Copy Markdown
Owner

@bhuber2010 need help with these PR's, especially with ng-packagr is failing. once done aim is first to ng 10 and then eventually to ng11 and ng12 (supporting all intermediate versions)

and finally we're showcasing it on fulls1z3/universal#755

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fulls1z3 fulls1z3 Awaiting requested review from fulls1z3 fulls1z3 is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@bhuber2010 @fulls1z3